D24862: Port one of session management connections state to a custom API
Vlad Zahorodnii
noreply at phabricator.kde.org
Fri Nov 1 10:12:20 GMT 2019
zzag added inline comments.
INLINE COMMENTS
> zzag wrote in sm.cpp:377-384
> Style: Case labels should not be indented.
>
> ---
>
> Also, I'd prefer to be more explicit about the conversion between "d-bus enums" and our enums, i.e. use integer values in the case labels.
>
> Another way to implement this method without encoding "d-bus enum" values in our types is to use a static QVector and value() method.
>
> I don't have a strong opinion though. It's up to you whether to leave this method as is. However, please fix the coding style issue.
s/integer values/integer literals/
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D24862
To: davidedmundson, #kwin, zzag, apol
Cc: romangg, zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191101/f720e0dc/attachment-0001.html>
More information about the kwin
mailing list