D21948: [colorcorrection] Add "Constant" mode

[Roman Gilg]

romangg added a comment.


  In D21948#487369 <https://phabricator.kde.org/D21948#487369>, @davidedmundson wrote:
  
  > I fully support a better split of colour correct and night mode, with nightmode being an interface into colour correction. 
  >  I didn't like really "nightmode" being an explicit part of kwin.
  
  
  I didn't say Night Color should be an interface only per se. Currently we do the timing calculation in KWin to always have the correct timings and color values at hand immediately without flashing frames with wrong temperature. To do this out of process we would need to block KWin's present on hardware until the temperature supplying process gives us the current value. Another aspect is when temperature changes over time. Do we have a timer in KWin or do we send progressively new values from the other process?
  
  But it's worth investigating. Sun calculations don't really belong in a window compositor.
  
  > However imho we still want a constant toggle on the nightmode public api to integrate into something that can be feature complete with the current redshift plasmoid. Having that go into a different api would be messy and have potential conflicts at runtime.
  
  The redshift plasmoid targeted X and imo feature completeness with it shouldn't be a development target for us. The constant factor you can apply there is just for convenience on X because you never know what other ui you have in the DE the user runs for doing such things. In our Wayland session we can do this in an integrated way once instead of being spread over several little tools. And to be honest there is not much stopping us from doing it the same way on X11. KGamma just sucks.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D21948

To: zzag, #kwin
Cc: davidedmundson, romangg, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190627/0a433843/attachment.html>