D22119: [RFC] [autotests] In internal window test remove spy waits or guard them

Roman Gilg noreply at phabricator.kde.org
Thu Jun 27 17:22:36 BST 2019


romangg added a comment.


  In D22119#487348 <https://phabricator.kde.org/D22119#487348>, @zzag wrote:
  
  > In D22119#487347 <https://phabricator.kde.org/D22119#487347>, @romangg wrote:
  >
  > > That's definitely a nice pattern and if we already use it at other places I will change the diff to that. Only downside I could see is that it does not explicitly check that the signal has been sent only once when waiting. But that's not necessary here.
  >
  >
  > You can do that with QTRY_COMPARE.
  
  
  True, I was under the impression it does something else. When I will use this one instead. Thanks!

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22119

To: romangg, #kwin
Cc: davidedmundson, zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190627/87955716/attachment.html>


More information about the kwin mailing list