D22109: [platformsupport] Minor code style and class variables access changes
Vlad Zagorodniy
noreply at phabricator.kde.org
Thu Jun 27 09:21:33 BST 2019
zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.
> Some of these variables have been declared protected but can apparently also be private.
That's because SceneOpenGLTexture and OpenGLWindowPixmap are fwends. It's somewhat weird to declare a friend class, which is specific to one scene, in a generic-ish class. On the other hand, we have only one OpenGL scene.
REPOSITORY
R108 KWin
BRANCH
styleOpenGlTexture
REVISION DETAIL
https://phabricator.kde.org/D22109
To: romangg, #kwin, zzag
Cc: zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190627/1e47e406/attachment.html>
More information about the kwin
mailing list