D21996: [autotests] Test placement strategies

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> zzag wrote in placement.cpp:61-66
> These two can be ordinary functions. Also, "doxygen" comments have to terminate with `**/`

Why would someone be generating doxygen of an internal class of an autotest?

Yes they could be functions, but there's a semantic link and we're not making a public API or anything

> zzag wrote in placement.cpp:105-108
> I personally see nothing wrong with duplicating this piece of code in each test.

Till we change something...

> zzag wrote in placement.cpp:121
> Missing QVERIFY.

You can't QVERIFY outside of a test function. It has an empty return.

If this was failing the shellClient test would be exploding, I think most people know to fix that first, which can leave this test to focus on placement.

> zzag wrote in placement.cpp:143
> Is it correct? It's null.

It was not. Thanks.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D21996

To: davidedmundson, #kwin
Cc: zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190625/c2327c29/attachment-0001.html>