D21965: Avoid crash without XWayland

Vlad Zagorodniy noreply at phabricator.kde.org
Fri Jun 21 14:51:34 BST 2019


zzag added inline comments.

INLINE COMMENTS

> shadow.cpp:127
>      QVector<uint32_t> ret;
>      if (id != XCB_WINDOW) {
>          Xcb::Property property(false, id, atoms->kde_net_wm_shadow, XCB_ATOM_CARDINAL, 0, 12);

It's a typo, right?

> shadow.cpp:363
> +
>      auto data = Shadow::readX11ShadowProperty(m_topLevel->window());
>      if (data.isEmpty()) {

What's the id of the Toplevel?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D21965

To: davidedmundson, #kwin
Cc: zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190621/24725050/attachment.html>


More information about the kwin mailing list