D18377: [effects/blur] Update blur to be more natural

[Fredrik Höglund]

fredrik added a comment.


  In D18377#480824 <https://phabricator.kde.org/D18377#480824>, @zzag wrote:
  
  > In D18377#480776 <https://phabricator.kde.org/D18377#480776>, @anemeth wrote:
  >
  > > I just downloaded the KDE Neon 5.16 iso from the website, installed it and updated it
  >
  >
  > You need an Intel graphics card to reproduce this bug.
  
  
  Yeah, the problem is probably that the GL_FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING is GL_LINEAR with the Intel driver, and that means that the final conversion from linear to sRGB is not happening in the upscaleRenderToScreen() pass.
  
  We should probably not use sRGB textures when the driver reports that the framebuffer color encoding is linear.
  
  However, it might also be a bug in the driver that it doesn't pick an sRGB format for the default framebuffer. We should discuss that with the Intel developers, but I would appreciate it if someone who has an Intel GPU could investigate this a bit further first. At the very least confirm that glGetFramebufferAttachmentParameteriv() in fact returns GL_LINEAR.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D18377

To: anemeth, #vdg, #kwin, davidedmundson, zzag, fredrik, ngraham
Cc: ndavis, mvourlakos, Codezela, fredrik, abetts, Petross404, rapiteanu, filipf, rooty, ngraham, kwin, LeGast00n, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190616/cf1567c5/attachment-0001.html>