D22295: Remove scene check on repaints

Vlad Zagorodniy noreply at phabricator.kde.org
Mon Jul 15 14:25:28 BST 2019


zzag added inline comments.

INLINE COMMENTS

> romangg wrote in composite.cpp:583-584
> Yea, shouldn't be an issue. We can add as many we like and when compositing gets enabled again we do a repaint of the accumulated region (probably we do a full repaint then anyway).

It's better to avoid unnecessary work if compositing is disabled. Many parts of KWin call Compositor::addRepaint() without checking whether compositing is active, although some parts check.

Please add this check back.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22295

To: romangg, #kwin
Cc: zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190715/65f6d835/attachment.html>


More information about the kwin mailing list