D22195: Split Compositor class in Wayland and X11 child classes

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> romangg wrote in composite.h:49
> We should change what this file says then. As said, let's discuss this at KWin sprint.

I don't see any reason why we should switch the coding style. KWin's been following the kdelibs coding style since 2009 or since when Martin reformatted the code.

> As said, let's discuss this at KWin sprint.

Okay, but as I said, I don't see any reason to switch. Pointer alignment based on context is pretty weak because from time to time one should ask himself how a pointer/reference has to be aligned. People will also get it wrong. Heck, we have issues even with aligning pointers and references always to right.

Another disadvantage of the proposed pointer alignment scheme is that it's quite exotic and rare. Think of it as our current 
Doxygen comment style. `/** **/` looks balanced and neat, but most people don't use it. They instead prefer `/** */`, more common style.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22195

To: romangg, #kwin
Cc: sbergeron, anthonyfieroni, zzag, kwin, LeGast00n, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190715/baf66c95/attachment-0001.html>