D22379: Don't use deprecated QDesktopWidget

David Edmundson noreply at phabricator.kde.org
Wed Jul 10 15:24:50 BST 2019


davidedmundson added inline comments.

INLINE COMMENTS

> zzag wrote in monitor.cpp:54
> Is there nicer way to retrieve QScreen from QWidget?

I'm not really sure it's that important. You have one preview, but the thing you're affecting changes all N screens.

Showing dimensions of the primary screen is just as valid.

Also the previous use of availableGeometry is almost certainly wrong. It's a preview of a monitor, therefore why exclude panels?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22379

To: zzag, #kwin
Cc: davidedmundson, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190710/8e8fb3b4/attachment.html>


More information about the kwin mailing list