D22342: Fix potential lockups with swap events

[Fredrik Höglund]

fredrik created this revision.
fredrik added a reviewer: KWin.
fredrik added a project: KWin.
Herald added a subscriber: kwin.
fredrik requested review of this revision.

REVISION SUMMARY
  This series should hopefully fix the lockups that some users have been experiencing with swap events enabled.
  
  commit 076c6a8de05219800dd922827a223b345cdbc193 (HEAD -> swap-event-fixes)
  Author: Fredrik Höglund <fredrik at kde.org>
  Date:   Sun May 12 14:21:03 2019 +0200
  
    Remove the assert() in Compositor::bufferSwapComplete()
  
  commit d9765fdb51be90718190c6495de5c8a9aa400fc3
  Author: Fredrik Höglund <fredrik at kde.org>
  Date:   Sun May 12 14:19:12 2019 +0200
  
    Set m_bufferSwapPending to false in Compositor::finish()
    
    Othewise we can end up waiting forever if compositing was suspended
    while a swap event was pending.
  
  commit da1b607722e6fff5290b1e6d4c73447b8ac5444e
  Author: Fredrik Höglund <fredrik at kde.org>
  Date:   Sun May 12 14:17:36 2019 +0200
  
    Don't call performCompositing() directly from bufferSwapComplete()
    
    Start the composite timer instead, so we don't call performCompositing()
    from the event handler.

TEST PLAN
  I've been running kwin with these patches and swap events enabled for a couple of months without experiencing any lockups.
  
  Keep in mind that swap events must be enabled by setting KWIN_USE_INTEL_SWAP_EVENT to 1 when testing these changes.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22342

AFFECTED FILES
  composite.cpp

To: fredrik, #kwin
Cc: kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190709/34fa587f/attachment.html>