D18157: Remove Client fullscreen hack

Roman Gilg noreply at phabricator.kde.org
Mon Jul 8 22:02:09 BST 2019


romangg added a comment.


  In D18157#492476 <https://phabricator.kde.org/D18157#492476>, @zzag wrote:
  
  > Argh, never mind. Those patches are already in master.
  >
  > Please do cleanups before fixing coding style in the future, so git history looks sane.
  
  
  I don't agree that then git history in general looks more sane nor that it's an important goal to optimize for. It has very low priority in comparison to making the code work without bugs. On the other side doing the coding style fix before refactoring makes the refactoring simpler. Since regressions are more likely to be introduced on refactoring than on code style changes the latter should be done first to make regressions less likely on refactor.

REPOSITORY
  R108 KWin

BRANCH
  fullscreenHackRemoval

REVISION DETAIL
  https://phabricator.kde.org/D18157

To: romangg, #kwin, zzag
Cc: zzag, graesslin, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190708/598e7a42/attachment.html>


More information about the kwin mailing list