D22287: [colorcorrection] Introduce toggle Night Color shortcut

[Vlad Zagorodniy]

zzag marked an inline comment as done.
zzag added inline comments.

INLINE COMMENTS

> broulik wrote in manager.cpp:172
> Everywhere else in KWin (and other apps) we use a `KActionCollection` for this:
> 
>   m_actionCollection = new KActionCollection(this, QStringLiteral("kwin"));
>   m_actionCollection->setComponentDisplayName(i18n("KWin"));
> 
> with `m_actionCollection->addAction` (which sets the `objectName`)

> Everywhere else in KWin

That's inaccurate.

We don't use KActionCollection in KWin core because we don't need most of its features.

> broulik wrote in manager.cpp:176
> Given we don't actually set a shortcut, isn't
> 
>   KGlobalAccel::self()->setShortcut(action, QList<QKeySequence>{});
> 
> the proper way?

That's a copy-paste thing.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22287

To: zzag, #kwin
Cc: broulik, davidedmundson, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190705/1104eaa2/attachment-0001.html>