D22277: Save Compositor state in single variable

Roman Gilg noreply at phabricator.kde.org
Thu Jul 4 20:55:53 BST 2019


romangg added inline comments.

INLINE COMMENTS

> zzag wrote in composite.cpp:321-323
> I'm more interested in whether m_state can be State::Off by this time.

I would say in all relevant cases no. On X we always call from start() directly. On Wayland it should be only called through the signal once in the beginning and if at the same time it gets stopped we have likely some fatal problem anyway. We could investigate this more in the future but I feel it's not worth the time

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22277

To: romangg, #kwin
Cc: zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190704/cda2572f/attachment-0001.html>


More information about the kwin mailing list