D22277: Save Compositor state in single variable

Roman Gilg noreply at phabricator.kde.org
Thu Jul 4 18:39:19 BST 2019


romangg added inline comments.

INLINE COMMENTS

> zzag wrote in composite.cpp:174
> Starting compositor while it's being turned down will lead to a catastrophe. Thus, it can be simplified to m_state != State::Off.

I'm actually not sure on that one. All the starting and stopping is done in sequence. So it might be possible to begin starting again while the stopping has not fully been finished.

This could happen in theory when compositing is quickly toggled on and off by a client.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22277

To: romangg, #kwin
Cc: zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190704/141709b1/attachment-0001.html>


More information about the kwin mailing list