D22277: Save Compositor state in single variable

Roman Gilg noreply at phabricator.kde.org
Thu Jul 4 18:01:53 BST 2019


romangg created this revision.
romangg added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
romangg requested review of this revision.

REVISION SUMMARY
  Replace the several internal state booleans of Compositor with a single
  enum to register the current state of the compositor. We register four
  states of starting, started, stopping and stopped.
  
  The goal is to replace the several different conditionals when starting
  and stopping the compositor with a single well defined flow.
  
  There are currently still some ugly conditionals and some replaced ones
  might need some more work.

TEST PLAN
  Manually in X and Wayland. Relevant auto tests pass.

REPOSITORY
  R108 KWin

BRANCH
  compositorState

REVISION DETAIL
  https://phabricator.kde.org/D22277

AFFECTED FILES
  composite.cpp
  composite.h

To: romangg, #kwin
Cc: kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190704/e0bf8bf8/attachment-0001.html>


More information about the kwin mailing list