D22218: Use new slot syntax in Compositor class

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> composite.h:170-171
>  
> -protected:
> -    void timerEvent(QTimerEvent *te);
> -

Please keep it protected.

> romangg wrote in composite.h:85
> There is a invokeMethod call to it.

In general I don't see why making it Q_INVOKABLE is better than keeping as a slot. Either keep it as Q_SLOT or use QTimer::singleShot(0).

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22218

To: romangg, #kwin
Cc: davidedmundson, zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190702/f4d40ee3/attachment-0001.html>