zzag added inline comments.
INLINE COMMENTS
> composite.h:41-46
> + enum SuspendReason { NoReasonSuspend = 0,
> + UserSuspend = 1<<0,
> + BlockRuleSuspend = 1<<1,
> + ScriptSuspend = 1<<2,
> + AllReasonSuspend = 0xff
> + };
Please reindent it to
enum SuspendReason {
NoReasonSuspend,
UserSuspend = 1 << 0,
// ...
};
> composite.h:85
> **/
> - void suspend(Compositor::SuspendReason reason);
> + Q_INVOKABLE void suspend(Compositor::SuspendReason reason);
> +
Why is it Q_INVOKABLE?
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D22218
To: romangg, #kwin
Cc: zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190702/54e5459a/attachment.html>