D21996: [autotests] Test placement strategies

Vlad Zagorodniy noreply at phabricator.kde.org
Tue Jul 2 16:13:20 BST 2019


zzag accepted this revision.
zzag added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> davidedmundson wrote in placement.cpp:151
> Done, but we need to take this "auto" discussion to frameworks-devel and make an actual policy.

A bit radical claim: I suggest to prohibit `auto` in kwin because many people abuse it. We could use it with only a few things, like iterators.

  auto foo = bar();

is just wrong. I know that I did this too, but it's just wrong.

Anyways, that's out of scope of this patch.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21996

To: davidedmundson, #kwin, zzag
Cc: zzag, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190702/c8c8fb99/attachment.html>


More information about the kwin mailing list