D22150: [plugins/qpa] Implement native offscreen surface
Roman Gilg
noreply at phabricator.kde.org
Mon Jul 1 20:05:32 BST 2019
romangg added inline comments.
INLINE COMMENTS
> zzag wrote in sharingplatformcontext.cpp:101
> FWIW we can do
>
> if (surface->surface()->surfaceClass() == QSurface::Window) {
> Window *window = static_cast<Window *>(surface);
> }
>
> if `dynamic_cast` should go away.
Also a good solution. Question is how often is this called if it's worth the potential performance gain. Decide before pushing what you like more and then push with or without it.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D22150
To: zzag, #kwin, romangg
Cc: romangg, alexeymin, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190701/705191c0/attachment.html>
More information about the kwin
mailing list