D25949: KCM KWinDecoration port to KConfigXT

[Kevin Ottens]

ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Just a small nitpick, otherwise looks fine to me.

INLINE COMMENTS

> Buttons.qml:235
>                  color: palette.windowText
> -                opacity: (leftButtonsView.dragging || rightButtonsView.dragging || availableButtonsGrid.dragging) ? 0.0 : 1.0
> +                opacity: (leftButtonsView.dragging || rightButtonsView.dragging || availableButtonsGrid.dragging) ? 0.0 : enabled ? 1.0 : 0.3
>                  Layout.fillWidth: true

I think it'd be worth splitting that up in several sub-expressions using properties just to improve readability.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25949

To: crossi, #kwin, ervin, bport, mart, davidedmundson
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191223/28978887/attachment.html>