D25881: [KCM/Desktop] Port from KQuickAddons::ConfigModule to ManagedConfigModule

[Vlad Zahorodnii]

zzag added a comment.


  This patch looks good to me.

INLINE COMMENTS

> animationsmodel.cpp:140
> +{
> +    const bool enabledByDefault = index(m_currentIndex,0).data(EnabledByDefaultRole).toBool();
> +    return enabledByDefault;

Heh, it took a couple of minutes to decipher what this method is doing. Could you please add an explanatory comment why it's okay to check only `EnabledByDefaultRole` and **not** `StatusRole`?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25881

To: meven, #kwin, ervin, crossi
Cc: zzag, bport, crossi, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191220/a3841609/attachment-0001.html>