D26040: [KCM/Effects] Allow the user to know when the settings are set to default
Méven Car
noreply at phabricator.kde.org
Fri Dec 20 12:26:11 GMT 2019
meven marked an inline comment as done.
meven added inline comments.
INLINE COMMENTS
> zzag wrote in effectsmodel.cpp:571
> This inline comment hasn't been addressed.
>
> I asked you to remove a `else` after a `return` statement, i.e.
>
> if (effect.enabledByDefaultFunction && effect.status != Status::EnabledUndeterminded) {
> return false;
> }
> if ((bool)effect.status != effect.enabledByDefault) {
> return false;
> }
> return true;
I misunderstood what you meant, in my last change I added :
} else {
return true;
}
Should be good now
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D26040
To: meven, #kwin, crossi, ervin
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191220/57115557/attachment-0001.html>
More information about the kwin
mailing list