D26040: [KCM/Effects] Allow the user to know when the settings are set to default

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> zzag wrote in effectsmodel.cpp:571
> No `else` after a return statement.

This inline comment hasn't been addressed.

I asked you to remove a `else` after a `return` statement, i.e.

  if (effect.enabledByDefaultFunction && effect.status != Status::EnabledUndeterminded) {
      return false;
  }
  if ((bool)effect.status != effect.enabledByDefault) {
      return false;
  }
  return true;

> meven wrote in kcm.cpp:55
> dataChanged signal is only emitted in EffectsModel::setData

Oh, you're right! You could also consider using one of QAbstractItemModel's signals instead, e.g. modelReset. Perhaps EffectsModel::loaded() should not exist in the first place.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D26040

To: meven, #kwin, crossi, ervin
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191220/61b867d1/attachment.html>