D25881: [KCM/Desktop] Port from KQuickAddons::ConfigModule to ManagedConfigModule

[Cyril Rossi]

crossi added a comment.


  Still some minor issue, looking good otherwise.

INLINE COMMENTS

> desktopsmodel.h:96
>  
> +    bool needsSave();
> +    void load();

should be const

> desktopsmodel.h:99
> +    void defaults();
> +    bool isDefaults();
> +

should be const

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25881

To: meven, #kwin, ervin, crossi
Cc: bport, crossi, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, zachus, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191217/6f151e25/attachment.html>