D26040: [KCM/Effects] Allow the user to know when the settings are set to default

Vlad Zahorodnii noreply at phabricator.kde.org
Mon Dec 16 10:19:53 GMT 2019


zzag added inline comments.

INLINE COMMENTS

> effectsmodel.cpp:568
> +{
> +    for (int i = 0; i < m_effects.count(); ++i) {
> +        const auto &effect = m_effects.at(i);

Minor thing, but could you please use std::all_of?

> effectsmodel.h:195
> +     */
> +    bool isDefaults();
> +

Make it const please.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D26040

To: meven, #kwin, crossi, ervin
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191216/38f8f54e/attachment-0001.html>


More information about the kwin mailing list