D25921: [libinput] Send touch events with respect to device rotation

Vlad Zahorodnii noreply at phabricator.kde.org
Fri Dec 13 09:16:41 GMT 2019


zzag accepted this revision.
zzag added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> connection.cpp:254
> +#ifndef KWIN_BUILD_TESTING
> +QPointF devicePointToGlobalPosition(const QPointF &devicePos, const AbstractWaylandOutput *output)
> +{

Can be `static`.

> connection.cpp:259
> +    QPointF pos = devicePos;
> +    // TODO: Do we need to handle the flipped cases differently?
> +    switch (output->transform()) {

Yeah, I think so.

BRANCH
  touch-rotation-fix

REVISION DETAIL
  https://phabricator.kde.org/D25921

To: romangg, #kwin, zzag
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191213/b7993ca1/attachment.html>


More information about the kwin mailing list