D25913: Possible fix for KDecoration crash in systemsettings

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.

REVISION SUMMARY
  I could never reproduce the crash, but we know from gdb that it's from
  the decorationSettings object
  
  We are setting the same QObject instance as a context property in
  multiple contexts at once. This is already slightly odd especially from the POV of
  Qt's internal property cache.
  
  Given we want one object to be exposed to all contexts, we can expose it
  to the parent context only once and achieve the same result in a simpler
  way.
  
  BUG: 411166

TEST PLAN
  Verified opening and closing system settings still worked for me.
  I could never reproduce the original crash.

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25913

AFFECTED FILES
  plugins/kdecorations/aurorae/src/aurorae.cpp

To: davidedmundson, #kwin
Cc: kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191212/0064e5a1/attachment.html>