D25904: [libkwineffects] Set original backend framebuffer for render targets

[Roman Gilg]

romangg added a comment.


  In D25904#575886 <https://phabricator.kde.org/D25904#575886>, @zzag wrote:
  
  > Hmm, okay, fair enough. Can you rename `setKWinFramebuffer` to `setDefaultFramebufferObject`? It's not clear what "kwin framebuffer" is.
  
  
  I used the name `s_defaultFramebuffer` all the time in my working branch but changed it now for upload. ;)
  
  The reason is that the Default Framebuffer is in OpenGl a fixed notation that names the framebuffer with id `0`, see [1].
  
  Since we have this here to use it also with framebuffer objects the variable would need some other name. But I'm open to other suggestions. I thougth of `originalFramebuffer` or `backendFramebuffer`.
  
  [1] https://www.khronos.org/opengl/wiki/Default_Framebuffer

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25904

To: romangg, #kwin
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191211/97b1a6f3/attachment-0001.html>