D25906: [platforms/drm] Add hardware transformation API
Vlad Zahorodnii
noreply at phabricator.kde.org
Wed Dec 11 21:47:25 GMT 2019
zzag added inline comments.
INLINE COMMENTS
> drm_output.cpp:654
> + {
> + using OutTrans = DrmOutput::Transform;
> + using PlaneTrans = DrmPlane::Transformation;
Use full name, e.g. OutputTransform.
> drm_output.cpp:703
> +
> + if (!qEnvironmentVariableIsSet("KWIN_DRM_SW_ROTATIONS_ONLY") &&
> + (m_primaryPlane->supportedTransformations() & planeTransform) &&
Please omit "rotation" in the environment variable name and use something more generic, e.g. "output transforms," etc.
> drm_output.h:92
> + */
> + bool hardwareTransforms() const;
> +
Rename it to `supportsHardwareTransforms`.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D25906
To: romangg, #kwin
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191211/f2ff3dd2/attachment.html>
More information about the kwin
mailing list