D25881: [KCM/Desktop] Port from KQuickAddons::ConfigModule to ManagedConfigModule

[Cyril Rossi]

crossi added a comment.


  Some qml nitpicks on signal handler

INLINE COMMENTS

> main.qml:177
> +                checked: kcm.virtualDesktopsSettings.rollOverDesktops
> +                onCheckedChanged: kcm.virtualDesktopsSettings.rollOverDesktops = checked
>              }

Consider using onToggled, like other checkbox below.

> main.qml:254
>  
> -                    onValueChanged: kcm.osdDuration = value
> +                    onValueChanged: kcm.virtualDesktopsSettings.popupHideDelay = value
>                  }

Consider using onValueModified instead which fires when modified by user.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25881

To: meven, #kwin, ervin
Cc: crossi, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191211/eeed56ca/attachment-0001.html>