D25881: [KCM/Desktop] Port from KQuickAddons::ConfigModule to ManagedConfigModule

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> virtualdesktops.cpp:71
>  
> +VirtualDesktopsSettings *VirtualDesktops::virtualDesktopsSettings() const {
> +    return m_settings;

The opening curly braces should be on their own line.

> virtualdesktops.cpp:93
>  
>      setNeedsSave(false);
>  }

Likely not needed anymore.

> virtualdesktops.cpp:163
>  
>  void VirtualDesktops::updateNeedsSave()
>  {

The whole function is likely unneeded now

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25881

To: meven, #kwin, ervin
Cc: kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191211/25539181/attachment.html>