D25871: [KCM/Desktop] Use KConfig XT to store virtualdesktops related settings

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> virtualdesktops.cpp:173
>  
>      setNavWraps(true);
>      setOsdEnabled(false);

I would like this to to take these settings from the kcfg defaults

> virtualdesktops.cpp:250
>  
> -    KConfigGroup navConfig(m_kwinConfig, "Windows");
> -
> -    if (m_navWraps != navConfig.readEntry<bool>("RollOverDesktops", true)) {
> +    if (m_navWraps != m_settings->rollOverDesktop()) {
>          needsSave = true;

Out of curiosity, is there anything blocking us using KQuickAddons::ManagedConfigModule as the base?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25871

To: meven, #kwin, ervin
Cc: davidedmundson, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191211/387b2591/attachment.html>