D25871: [KCM/Desktop] Use KConfig XT to store virtualdesktops related settings

[Kevin Ottens]

ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Mostly looks good, needs some tuning in the kcfg to make the generated code API nicer on the C++ side.

INLINE COMMENTS

> virtualdesktopssettings.kcfg:8
> +  <group name="Windows">
> +    <entry name="rolloverdesktop" key="RollOverDesktops" type="bool">
> +      <label>Whether or not, we circle through the virtual desktop when moving from one to the next</label>

I'd use rollOverDesktop for the name parameter to have proper camel casing on the C++ side

> virtualdesktopssettings.kcfg:14
> +  <group name="Plugins">
> +    <entry name="desktopchangeosdEnabled" key="desktopchangeosdEnabled" type="bool">
> +      <label>Display in an OSD the virtual desktop name when switching between virtual desktops</label>

I'd use desktopChangeOsdEnabled for the name parameter to have proper camel casing on the C++ side

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25871

To: meven, #kwin, ervin
Cc: kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191211/5403b840/attachment-0001.html>