D25663: Initial support for tablets on Wayland

Vlad Zahorodnii noreply at phabricator.kde.org
Tue Dec 10 22:03:54 GMT 2019


zzag added inline comments.

INLINE COMMENTS

> romangg wrote in input.h:233
> I haven't seen these places. I always see in KWin code opening brackets on same line in this case. So I would prefer to be consistent in deviating from coding style here. Note also that getters `keyboard()`, `pointers()`,... directly above this new getter have opening brackets on the same line.
> 
> In the end best would be to always have member function definitions in the cpp file. But for small getters it's really a hassle...

There are places where we use the other style, but not that many. Hopefully, we'll fix these annoying style issues one day with a little help from beloved clang-format. ;-)

> In the end best would be to always have member function definitions in the cpp file.

++

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25663

To: apol, #plasma, #kwin, romangg
Cc: zzag, davidedmundson, romangg, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191210/5078f33c/attachment.html>


More information about the kwin mailing list