D25663: Initial support for tablets on Wayland
Roman Gilg
noreply at phabricator.kde.org
Tue Dec 10 18:31:18 GMT 2019
romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.
Looks good now. Some last style details to change, please fix them on commit.
INLINE COMMENTS
> connection.cpp:497
> + toolId,
> + event->device());
> + break;
unnecessary many lines. group xTilt, yTilt etc.
> connection.cpp:502
> + auto *tabletEvent = static_cast<TabletToolButtonEvent *>(event.data());
> + emit tabletToolButtonEvent(tabletEvent->buttonId(), tabletEvent->isButtonPressed());
> + break;
Line still too long.
> tablet_input.cpp:69
> + quint64 toolId,
> + LibInput::Device *device)
> +{
unnecessary many lines. group xTilt, yTilt etc.
> tablet_input.cpp:106
> + button,
> + button);
> +
unnecessary many lines. group xTilt, yTilt etc.
REPOSITORY
R108 KWin
BRANCH
input1
REVISION DETAIL
https://phabricator.kde.org/D25663
To: apol, #plasma, #kwin, romangg
Cc: zzag, davidedmundson, romangg, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191210/2d8ca1a7/attachment-0001.html>
More information about the kwin
mailing list