D25764: Provide a fake approach to tablet event propagation

Roman Gilg noreply at phabricator.kde.org
Fri Dec 6 08:03:02 GMT 2019


romangg added inline comments.

INLINE COMMENTS

> apol wrote in pointer_input.h:60
> I agree it's better as a function, I was asked to return a hash in this comment here
> https://phabricator.kde.org/D25663?id=70691#inline-144704
> 
> Maybe I misunderstood, @romangg can you confirm?

Yea, this was a misunderstanding. I meant there the internal representation should be changed to being a hash instead of a switch-statement in a separate patch (as you did in D25763 <https://phabricator.kde.org/D25763>), but I didn't mean that the getter should return the full hash,  only that the getter should be exposed as well in a separate patch.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25764

To: apol, #kwin
Cc: romangg, zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191206/52870dd4/attachment.html>


More information about the kwin mailing list