D25764: Provide a fake approach to tablet event propagation

Vlad Zahorodnii noreply at phabricator.kde.org
Thu Dec 5 17:24:28 GMT 2019


zzag added inline comments.

INLINE COMMENTS

> apol wrote in pointer_input.h:60
> Why add a function nobody needs? The function is already present, only not exposed to the header.

I'm asking you only to replace `buttonCodeToQt` with the utility function.

  // pointer_input.h
  
  uint32_t qtToButtonMouseButton(Qt::MouseButton button);
  
  // pointer_input.cpp
  
  uint32_t qtToButtonMouseButton(Qt::MouseButton button)
  {
      return s_buttonToQtMouseButton.key(button);
  }

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25764

To: apol, #kwin
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191205/1f9b61c4/attachment.html>


More information about the kwin mailing list