D25611: [scene] Fix decoration texture bleeding

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> scene_opengl.cpp:2625
> +        painter.setRenderHint(QPainter::Antialiasing);
> +        painter.setViewport(QRect(viewport.topLeft(), viewport.size() * devicePixelRatio));
> +        painter.setWindow(QRect(geo.topLeft(), geo.size() * devicePixelRatio));

QRect point should also be *= devicePixelRatio?

> scene_opengl.cpp:2670
> +
> +    // Reserve some space for padding. We pad decoration parts to avoid texture bleeding.
> +    const int padding = 1;

We rotate the vertical bars so everything is horizontal, so in theory we could:

GL_CLAMP_S=GL_CLAMP_TO_EDGE

and only pad T.

Though maybe that's just making things more complicated...

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D25611

To: zzag, #kwin
Cc: davidedmundson, fredrik, kwin, fvogt, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20191202/97f51c46/attachment-0001.html>