D23610: Fix orientation sensor DBus
David Edmundson
noreply at phabricator.kde.org
Sat Aug 31 18:42:45 BST 2019
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.
REVISION SUMMARY
Firstly, it was completely broken, no-one called registerObject.
Secondly deleting the adaptor doesn't really make sense, you'd still
leave the object valid, only have it broken. Docs of
QDBusAbstractAdaptor do say not to ever delete it manually.
Thirdly we don't need Q_CLASSINFO setting the DBus interface on the
exported item when we use an adaptor.
TEST PLAN
Manually added some setEnabled/disabled
Could now see the path
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23610
AFFECTED FILES
orientation_sensor.cpp
orientation_sensor.h
To: davidedmundson, #kwin
Cc: kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190831/aca9861d/attachment.html>
More information about the kwin
mailing list