D23605: Switch to Q_ASSERT

David Edmundson noreply at phabricator.kde.org
Sat Aug 31 17:32:16 BST 2019


davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kwineffects.cpp:938
>      foreach (const WindowQuad & quad, *this) {
> -#ifndef NDEBUG
> +#if !defined(QT_NO_DEBUG)
>          if (quad.isTransformed())

heh, if we're going to spend time porting these, we may as well have gone to

if (kwinLoggingCategory.isEnabled) and used the modern runtime version

REPOSITORY
  R108 KWin

BRANCH
  switch-to-qassert

REVISION DETAIL
  https://phabricator.kde.org/D23605

To: zzag, #kwin, davidedmundson
Cc: romangg, davidedmundson, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190831/bccaca96/attachment-0001.html>


More information about the kwin mailing list