D23600: [platforms/drm] Rework enablement and dpms switching

Roman Gilg noreply at phabricator.kde.org
Sat Aug 31 09:43:03 BST 2019


romangg created this revision.
romangg added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
romangg requested review of this revision.

REVISION SUMMARY
  This patch further refines output management.
  
  We go now through AbstractWaylandOutput virtual functions to enable and
  disable outputs.
  
  Dpms changes and enablement switches use separate code paths at start in the
  Drm backend code since they are similar but not the directly same. Common code
  is shared though, functions are renamed accordingly.
  
  Asserts have been put in place to better understand and check the control
  flow. A seemingly unnecessary call to DrmOutput::pageFlipped on reactivation
  after Vt switch has been removed to allow for that.
  
  In future patches we need to look additionally at the legacy mode switching
  code path which was and is still not working and better handling of the
  current monitor Dpms state. For example a monitor being switched off is not
  properly acted on and the workspace still expanded.

TEST PLAN
  With one and two monitors:
  
  - Dpms off/on
  - Vt switches
  - Screen disable/enable

REPOSITORY
  R108 KWin

BRANCH
  enablementDpmsRework

REVISION DETAIL
  https://phabricator.kde.org/D23600

AFFECTED FILES
  abstract_wayland_output.cpp
  abstract_wayland_output.h
  platform.cpp
  platform.h
  plugins/platforms/drm/drm_backend.cpp
  plugins/platforms/drm/drm_backend.h
  plugins/platforms/drm/drm_output.cpp
  plugins/platforms/drm/drm_output.h

To: romangg, #kwin
Cc: kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190831/4c1f2982/attachment.html>


More information about the kwin mailing list