D23098: [x11] Fix crash during tear down

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  That's a nice solution. On Wayland we spare us the additional connections and we don't need the boiler plate virtual function in Compositor class.

INLINE COMMENTS

> anthonyfieroni wrote in composite.cpp:1052
> qobject_cast is slower in some cases can you do it
> 
>   static QPointer<X11Compositor> x11;
>   if (!x11) {
>       x11 = qobject_cast<X11Compositor *>(Compositor::self());
>   }
>   return x11;

I can't imagine it making a big difference. For now we only need it in two setup functions being called not regularly. But do you have some data on the difference in performance? If it's called more often in the future it might be an idea to benchmark it.

REPOSITORY
  R108 KWin

BRANCH
  fix-crash

REVISION DETAIL
  https://phabricator.kde.org/D23098

To: zzag, #kwin, romangg
Cc: anthonyfieroni, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190830/2b4e88e5/attachment.html>