D23098: [x11] Fix crash during tear down

Anthony Fieroni noreply at phabricator.kde.org
Fri Aug 30 19:05:55 BST 2019


anthonyfieroni added inline comments.

INLINE COMMENTS

> composite.cpp:1052
> +{
> +    return qobject_cast<X11Compositor *>(Compositor::self());
> +}

qobject_cast is slower in some cases can you do it

  static QPointer<X11Compositor> x11;
  if (!x11) {
      x11 = qobject_cast<X11Compositor *>(Compositor::self());
  }
  return x11;

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23098

To: zzag, #kwin
Cc: anthonyfieroni, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190830/06f331dd/attachment.html>


More information about the kwin mailing list