D23480: [kwin/effects/presentwindows] Remove window dimming and move title bars to bottom

[Cameron Rodgers]

cameronrodgers added a comment.


  In D23480#521324 <https://phabricator.kde.org/D23480#521324>, @ngraham wrote:
  
  > Actually I found a UI regression that happens with this patch. There's now a white/gray line underneath the title:
  >
  > F7289321: Screenshot_20190828_112900.png <https://phabricator.kde.org/F7289321>
  
  
  Good catch. This seems to be related to the Blur effect, as it doesn't occur if Blur is turned off in Desktop Effects (in my KDE Neon VM). I agree it's a regression for the title bars, but this problem is actually more widespread. The current code (without this patch applied) already has the white/gray/transparent line around icons, and around (some) title bars. Here is a screenshot of the current Present Windows effect:
  F7289990: grayline.png <https://phabricator.kde.org/F7289990>
  Do we have any clues on how to prevent this? I'll be looking into it later.
  
  In D23480#521330 <https://phabricator.kde.org/D23480#521330>, @davidedmundson wrote:
  
  > If we do remove the highlight (and I'm willing to say, that's purely aesthetics and therefore not my realm) we should remove all the code that does the highlight.
  >
  > This still animates, and still updates every frame during the animation only to show the same value.
  
  
  Unfortunately, it appears that the highlight variable is also used in window scaling calculations:
  https://github.com/KDE/kwin/blob/master/effects/presentwindows/presentwindows.cpp#L369
  As a result, I think most or all of the code calculating the "highlight" still plays some role. Since "highlight" would no longer actually have anything to do with window brightness, would it be appropriate to rename the variables and functions to reflect the change in functionality?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23480

To: cameronrodgers, #kwin, #vdg, #plasma, ngraham
Cc: davidedmundson, ngraham, zzag, romangg, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190828/c6dcd56d/attachment.html>