D23473: [platforms/wayland] Create output devices

Vlad Zagorodniy noreply at phabricator.kde.org
Tue Aug 27 09:04:48 BST 2019


zzag added inline comments.

INLINE COMMENTS

> romangg wrote in wayland_output.h:56
> Why do you prefer this? I try to omit friend classes in general since it dilutes the concept of access restrictions.

The main reason is to avoid littering of public interface with implementation details of the class.

Also, if init() is public, it means that anybody can call it.

> I try to omit friend classes

Yeah, it's actually a good idea to use `friend` as less as possible, but sometimes we have to use it otherwise code may become ridiculous.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23473

To: romangg, #kwin
Cc: zzag, kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190827/3f9c2eb3/attachment-0001.html>


More information about the kwin mailing list