D23480: [kwin/effects/presentwindows] Remove window dimming and move title bars to bottom

[Cameron Rodgers]

cameronrodgers created this revision.
cameronrodgers added reviewers: KWin, VDG, Plasma.
cameronrodgers added a project: KWin.
Herald added a subscriber: kwin.
cameronrodgers requested review of this revision.

REVISION SUMMARY
  This patch removes the dimming on windows in Present Windows, but keeps the dimming on the background. It also moves the title bars to the bottom of the windows to further increase readability and ease of visual recognition. In order to prevent title bars overlapping windows, the spacing between windows in flexible grid is increased a bit. Here is a screenshot:
  https://imgur.com/a/ZUKDsD1
  IMO it is clearly much better looking and more useful this way.
  
  There is another revision being discussed that only changes window dimming, and includes a setting for it in the configs:
  https://phabricator.kde.org/D8388
  I think people in that discussion may be overthinking it. Shouldn't we make the simplest change first (before adding outline effects, etc)? I haven't seen anyone indicate that they actually like the darkening effect. It's visually confusing. Why not just get rid of it outright?
  
  Please feel free to merge this thread/mark duplicate if you think it's appropriate (though this isn't an exact duplicate, and changes the title bars), I am new and don't know the methodology here. I just hope that these two issues are fixed soon, since they are simple fixes.

TEST PLAN
  Apply patch to kwin, compile, and run to see the change.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23480

AFFECTED FILES
  effects/presentwindows/presentwindows.cpp

To: cameronrodgers, #kwin, #vdg, #plasma
Cc: kwin, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190826/ed678114/attachment.html>