D23415: Improve comprehensibility and consistency of window placement mode names

[Nathaniel Graham]

ngraham added a comment.


  I've standardized on the descriptive mood now. But I have not reverted back to "Smart" because it's simply a bad name, and it doesn't make sense to keep it. It doesn't matter what the feature is called internally, and how long it's had that name is irrelevant if it's a bad name. And "Smart" is a bad name because unlike all the other window placement modes, it is a generic meaningless term whose name does not explain or hint at what it will do. User-visible strings are crafted for the benefit of the user, not the developer.
  
  Also I don't think renaming the enums is a good idea:
  
  - If the point is to retain naming consistency throughout the codebase, then we'd need to update the strings written to and read from the config files as well, which would necessitate a kconf update script, which seems like total overkill; no other KDE project imposes such a high bar for simple string changes
  - If, to avoid the above, we just rename the enums but not all occurrences in the codebase, then we haven't actually maintained consistency, and there's no point in doing any code renaming at all

REPOSITORY
  R108 KWin

BRANCH
  better-window-placement-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23415

To: ngraham, #kwin, #vdg, ndavis
Cc: zzag, ndavis, kwin, kde-doc-english, LeGast00n, The-Feren-OS-Dev, sbergeron, jraleigh, gennad, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, hardening, romangg, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190825/380c19b3/attachment.html>