D23069: Remove disabled TabGroup feature
Frederik Gladhorn
noreply at phabricator.kde.org
Tue Aug 13 07:17:19 BST 2019
gladhorn added a comment.
In D23069#510934 <https://phabricator.kde.org/D23069#510934>, @graesslin wrote:
> Just for the record: the patch to add window decoration back is in D13459 <https://phabricator.kde.org/D13459> - I still have the code around and uncommitted changes on top. With the relatively small changes I had window tabs kind of working already. So if anyone wants to pick it up: we are almost there and I'm happy to share the code. Personally I doubt that I will find the time to finish it. I currently don't even find the time to push accepted changes. I'd love to do it, but I must be realistic.
>
> On this change: we also have window tabs in the window rule system and also in the configuration system (e.g. middle click to move tabs).
Hi Martin, it's great to hear from you :)
I wish pushing accepted changes was easier, I find it takes too much effort indeed (gitlab will hopefully make that better). I hope others can pick up your changes.
I wonder how popular the feature is, do we have any idea how many users it had? I have never used it personally, but that doesn't mean anything.
Since I'm so much on the sidelines and won't put major work into KWin either, I'll leave it up to the maintainers to make a call. This was just an attempt to remove about ten lines of code initially, which then turned way bigger than I imagined.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D23069
To: gladhorn, #kwin
Cc: romangg, graesslin, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190813/ac8a372c/attachment-0001.html>
More information about the kwin
mailing list