D23098: Don't crash when X11Compositor tears down

[Roman Gilg]

romangg added a comment.


  In D23098#510410 <https://phabricator.kde.org/D23098#510410>, @zzag wrote:
  
  > In D23098#510409 <https://phabricator.kde.org/D23098#510409>, @romangg wrote:
  >
  > > Thanks, makes sense. Then just add a default implementation in base class doing nothing? Or will it then still try to access the overriding subclass method?
  >
  >
  > It doesn't matter whether default implementation is provided. All updateCompositingBlocked() method calls will be dispatched to Compositor, not X11Compositor or WaylandCompositor.
  
  
  I thought the root problem is that updateCompositeBlocking is pure virtual in Compositor and so not defined after child has been destroyed. Make it only virtual with a default implementation. Then on destroy updateCompositeBlocking calls will go to Compositor's default implementation and we won't crash. Something wrong with this logic?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D23098

To: zzag, #kwin
Cc: romangg, kwin, LeGast00n, sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kwin/attachments/20190811/462861db/attachment-0001.html>